Conversation
Inphi
force-pushed
the
inphi/vm-state-version
branch
from
ce6fe8d to
46723b2
Compare
mbaxter
reviewed
Sep 23, 2024
Co-authored-by: mbaxter <[email protected]>
Contributor
|
This is sick |
pegahcarter
reviewed
Sep 25, 2024
cannon-state-versioning.md
Outdated
| ## Supporting new cannon embeds | ||
|
|
||
| While every version of cannon can be embedded into the cannon CLI, this can result in a really large binary. | ||
| Instead, the Cannon CLI only needs to maintain the VM implemnetations that it's likely to use. |
Contributor
|
Is there anything left to do on this doc? It seems ready to for any last reviews and to be merged, especially since the code changes are already merged. 🙂 |
Contributor
Author
it's good to merge. I can do so tomorrow |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for handling changes to the offchain Cannon STF.