feat: operator fee scalar fix#299
Merged
geoknee merged 4 commits intoethereum-optimism:mainfrom Aug 1, 2025
Merged
Conversation
Contributor
|
Could you add some additional fields to the table that make it easy to see how much USD is charged? ie an ETH/USD assumption and then a USD fee charged. This will help to make sure that the thing that impacts the end user is accounted for |
Contributor
|
Do you mind calling out the parts of the codebase that will need to change? I believe no change to |
geoknee
reviewed
Aug 1, 2025
geoknee
reviewed
Aug 1, 2025
geoknee
reviewed
Aug 1, 2025
sebastianst
reviewed
Aug 1, 2025
geoknee
reviewed
Aug 1, 2025
geoknee
approved these changes
Aug 1, 2025
Contributor
geoknee
left a comment
There was a problem hiding this comment.
We got good alignment on the review call. Just need to update the table and then we can merge the PR (ratify it).
This was referenced Sep 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the current operator fee formula.
The
1e-6multiplier on theoperatorFeeScalaris not useful for operators as it results in a fee that is too low to be useful. This design doc proposes the following change to the operator fee formula.With the new fee formula, here are some examples of some possible fees being charged.
For the dollar cost column, we assume an ETH price of 2.5k.
operatorFeeScalaroperatorFeeScalar * gasUsed * 100Fixes ethereum-optimism/optimism#16623