Conversation
blmalone
changed the title
blmalone
commented
Nov 6, 2024
mds1
reviewed
Nov 6, 2024
mds1
reviewed
Nov 6, 2024
mds1
reviewed
Nov 6, 2024
mds1
reviewed
Nov 6, 2024
mds1
reviewed
Nov 6, 2024
mds1
reviewed
Nov 6, 2024
mds1
reviewed
Nov 6, 2024
mds1
reviewed
Nov 6, 2024
mds1
reviewed
Nov 6, 2024
mslipper
reviewed
Nov 6, 2024
mslipper
reviewed
Nov 6, 2024
mslipper
approved these changes
Nov 6, 2024
Contributor
mslipper
left a comment
mslipper
left a comment
There was a problem hiding this comment.
Looks great! Left a few non-blocking comments.
maurelian
previously requested changes
Nov 6, 2024
maurelian
dismissed
their stale review
Didn't mean to use the big bad "REQUEST CHANGES" button
Co-authored-by: Maurelian <john@oplabs.co>
blmalone
deleted the
11-05-opcm-redesign_redesigning_opcm_with_upgrades_in_mind
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
OPCM requires a redesign based on recent conversations highlighting the need for upgrade functionality. This design doc is preemtively making some changes to make introducing upgradability features to OPCM easier.
Additional context
Ongoing discussions happening in Optimism R&D discord.