This repository has been archived by the owner on Apr 12, 2021. It is now read-only.
[wip] OVM self-upgradability #357
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er.sol Co-authored-by: smartcontracts <[email protected]>
…er.sol Co-authored-by: smartcontracts <[email protected]>
…er.sol Co-authored-by: smartcontracts <[email protected]>
…er.sol Co-authored-by: smartcontracts <[email protected]>
…er.sol Co-authored-by: smartcontracts <[email protected]>
| onlyCallableBy(address(0x4200000000000000000000000000000000000009)) | ||
| { | ||
| _checkAccountLoad(_address); | ||
| ovmStateManager.putAccountCode(_address, _code); |
There was a problem hiding this comment.
I think we need to be very explicit about the security considerations here. Primarily w/r/t how fraud proofs are impacted, what's safe to do, what isn't. etc.
contracts/optimistic-ethereum/libraries/wrappers/Lib_SafeExecutionManagerWrapper.sol
Outdated
Show resolved
Hide resolved
| @@ -322,6 +322,24 @@ library Lib_SafeExecutionManagerWrapper { | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * Performs a safe asdfasdfasdfasdf call. | |||
There was a problem hiding this comment.
Reminder to update this.
| function getAccount(address _address) external view returns (Lib_OVMCodec.Account memory _account); | ||
| function hasAccount(address _address) external view returns (bool _exists); | ||
| function hasEmptyAccount(address _address) external view returns (bool _exists); | ||
| function setAccountNonce(address _address, uint256 _nonce) external; | ||
| function getAccountNonce(address _address) external view returns (uint256 _nonce); | ||
| function getAccountEthAddress(address _address) external view returns (address _ethAddress); | ||
| function getAccountStorageRoot(address _address) external view returns (bytes32 _storageRoot); | ||
| function initPendingAccount(address _address) external; | ||
| function initPendingAccount(address _address) external; // todo: deprecate/combine these two with this change? |
There was a problem hiding this comment.
Reminder on this todo
test/helpers/constants.ts
Outdated
| getContractDefinition('Helper_TestRunner').deployedBytecode | ||
| ).byteLength | ||
| } catch { | ||
| 1 |
There was a problem hiding this comment.
what does this line do?
There was a problem hiding this comment.
It stores a digital history of my typo :)
| import { Lib_ECDSAUtils } from "../../libraries/utils/Lib_ECDSAUtils.sol"; | ||
| import { Lib_SafeExecutionManagerWrapper } from "../../libraries/wrappers/Lib_SafeExecutionManagerWrapper.sol"; | ||
|
|
||
| contract OVM_Upgrader { |
There was a problem hiding this comment.
Also although IMO the name OVM_Upgrader is fine, we should take a few mins to brainstorm names + make sure the name won't be confusing going forward. Since it's much easier to change the name now than in the future, as we're well aware...
contracts/optimistic-ethereum/OVM/execution/OVM_ExecutionManager.sol
Outdated
Show resolved
Hide resolved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A clear and concise description of the features you're adding in this pull request.
Additional context
Add any other context about the problem you're solving.
Metadata