-
Notifications
You must be signed in to change notification settings - Fork 118
tests: fix the enums to match what is batch submitted #303
Conversation
@@ -23,7 +23,7 @@ contract OVM_SequencerEntrypoint { | |||
/********* | |||
* Enums * | |||
*********/ | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These whitespace diffs add noise to code review. We need linter rules that prevent such things from getting into the codebase
I'd expect the integration tests to fail |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the changes here look good to me; it's always been downstream that blocks here, so if you can get this through CI and have the clear upgrade path, I'm comfortable merging.
We will have to run our state diff tests because this will change the state root from the beginning, so checking state roots that match will not work. I pushed https://github.com/ethereum-optimism/contracts/tree/v0.1.4/enums to base these changes off of the contracts that are deployed to production right now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should prioritize #300 altho I am leaning towards the need to leave in the unmodified I also think its not a bad idea to add a |
Description
This is a requirement for ethereum-optimism/go-ethereum#255
The enums that were batch submitted to L1 were different than what the contracts expected, so geth had to fix them before passing along to the OVM. The above PR removes any logic in geth around modifying the transactions, it just passes the data through
Metadata
Fixes
Contributing Agreement