Conversation
|
TODO: update package.json to use new provider once merged |
annieke
force-pushed
the
feat/use_raw_transaction
branch
from
52d3c19 to
08d9461
Compare
karlfloersch
left a comment
karlfloersch
left a comment
There was a problem hiding this comment.
Awesome! There were a few comments left around but overall this PR is already looking quite good! Didn't look into why CI is failing but I'd imagine something super simple
annieke
force-pushed
the
feat/use_raw_transaction
branch
from
d034e60 to
79b016a
Compare
karlfloersch
left a comment
karlfloersch
left a comment
There was a problem hiding this comment.
Left one nit but this looks good!
Oh I also can't approve this PR cuz I created it whoops
| } | ||
| } | ||
|
|
||
| export const formatNumber = (num: any): number => { |
There was a problem hiding this comment.
Should this be num: string?
Is there a function which does this in core-utils? If not I think it's fine to include here but eventually probably a good idea to move it there
There was a problem hiding this comment.
i copied this from ethers formatter, which i think is supposed to keep the input general since it may begin as a number too
i'll move it into core-utils in a followup PR :)
This reverts commit d4de023.
2 participants
Overview
Addresses https://github.com/ethereum-optimism/roadmap/issues/757
Make the batch submitter use
rawTransactioninstead of doing crazy encoding.