806 endpoint to fetch state leaf based on cah #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ryHandler can be triggerd
…ee leaf value fetching
ognjenkurtic
requested review from
skarred14,
Therecanbeonlyone1969,
Kasshern,
Ybittan,
biscuitdey and
skosito
as code owners
| @@ -24,14 +24,18 @@ export class BpiMerkleTree { | |||
|
|
|||
| public addLeaf(leaf: string): void { | |||
| const bufferLeaf = Buffer.from(leaf, 'utf-8'); | |||
| this.tree.addLeaf(bufferLeaf, true); | |||
| this.tree.addLeaf(bufferLeaf, false); | |||
There was a problem hiding this comment.
why false? @ognjenkurtic
There was a problem hiding this comment.
since the leaf is already a sha265 hash, i thought that we do not need additional hashing when storing the leaf.
Therecanbeonlyone1969
deleted the
806-endpoint-to-fetch-state-leaf-based-on-cah
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extends the e2e test to verify that state and history tree entries are correct, as well as verify that the state tree leaf value can be correctly fetched by using content addressable hash.
Related Issue
#806
Motivation and Context
Verification that proper storage happens after each tx execution
How Has This Been Tested
e2e test extended
Screenshots (if appropriate)
Types of changes
Checklist