Api: Add miner_setverbosity(). #1382
Conversation
StefanOberhumer
force-pushed
the
ApiAddSetVerbosity
branch
from
a2c8916 to
f35310b
Compare
| if (!getRequestValue("verbosity", verbosity, jRequestParams, false, jResponse)) | ||
| return; | ||
|
|
||
| if (verbosity > 9) |
There was a problem hiding this comment.
Would suggest to check bounds 0 <-> 9 to avoid possible issues in setting negative values.
if (verbosity < 0 || verbosity > 9)
There was a problem hiding this comment.
As verbosity is unsigned I think it will never be "< 0" ;-)
There was a problem hiding this comment.
Sorry I read verbosity as int.
Nevertheless I would put the user in the condition to detect errors.
Setting an unsigned to -1 causes the same unsigned to get the max value
unsigned verbosity;
verbosity = -1;
produces verbosity = 4294967295 without throwing exception.
which of course breaks the constraint of being above 9 but we do not know if user have originally set 4294967295 or any negative number
Would rather set verbosity to int and check the range.
(only a suggestion).
There was a problem hiding this comment.
Hm... we should settle if we interpret the json request as int or unsigned!!!
If you look at miner_setactiveconnection, miner_removeconnection or miner_pausegpu we interpret the index as an unsigned.
Not sure if we should make some specials for miner_setverbosity ?
There was a problem hiding this comment.
Agree ... in fact I believe on those methods you mentioned I have made an error not foreseeing this condition.
libapicore/ApiServer.cpp
Outdated
| if (verbosity > 9) | ||
| { | ||
| jResponse["error"]["code"] = -422; | ||
| jResponse["error"]["message"] = "Verbosity out of bounds"; |
There was a problem hiding this comment.
jResponse["error"]["message"] = "Verbosity out of bounds (0-9)";
There was a problem hiding this comment.
👍 - Updated
StefanOberhumer
force-pushed
the
ApiAddSetVerbosity
branch
from
f35310b to
e5d3f00
Compare
StefanOberhumer
force-pushed
the
ApiAddSetVerbosity
branch
from
e5d3f00 to
ae9841a
Compare
AndreaLanfranchi
dismissed
their stale review
After a second and third reread of this code I realized that the overload of getRequestValue for unsigned already takes care of invalid input.
|
Sorry for letting this PR pending for so long. |
To identify problems on a running instance it is helpful to change the verbosity level without restarting.
This commit allows the change of verbosity via an API call.