This repository has been archived by the owner on Apr 24, 2022. It is now read-only.
Small fixes #1222
Merged
Small fixes #1222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Immediate binding to port 0 causes acceptor to find first available port and starts anyway.
Ping -> Pong
Maybe the issuer expects something.
chfast
approved these changes
Jun 5, 2018
chfast
reviewed
Jun 5, 2018
| @@ -40,7 +40,7 @@ static void diffToTarget(uint32_t *target, double diff) | |||
| } | |||
|
|
|||
|
|
|||
| EthStratumClient::EthStratumClient(boost::asio::io_service & io_service, int worktimeout, int responsetimeout, string const & email, bool const & submitHashrate) : PoolClient(), | |||
| EthStratumClient::EthStratumClient(boost::asio::io_service & io_service, int worktimeout, int responsetimeout, string email, bool submitHashrate) : PoolClient(), | |||
There was a problem hiding this comment.
If you are passing std::string by value you should also move it later on in
m_email(std::move(email))
There was a problem hiding this comment.
Actually m_email should be no longer needed as it's a legacy of old -O argument.
Will drop it in next jobs.
|
Add to CHANGELOG in ca5fdd5. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some tiny adjustments