Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bitkubchain Mainnet #1629

Merged
merged 13 commits into from
Feb 21, 2023
Merged

Add Bitkubchain Mainnet #1629

merged 13 commits into from
Feb 21, 2023

Conversation

ppanya
Copy link
Contributor

@ppanya ppanya commented Sep 21, 2022

Added Bitkub Chain, Replace Next Smart Chain (Old chain same chain id: 96)

Detail Genesis Block Next Smart chain: Block 0

  • Mainnet
    • Network ID: 96
    • Detail Genesis Block: Block 0

@ppanya
Copy link
Contributor Author

ppanya commented Oct 5, 2022

@ligi sorry, I want to know what the average time for pull request review or any progress?

@github-actions
Copy link

This PR has no activity in a while - it will be closed soon.

@github-actions github-actions bot added the Stale label Nov 17, 2022
@github-actions github-actions bot closed this Dec 1, 2022
@macvts
Copy link
Contributor

macvts commented Jan 14, 2023

@ligi can you provide some assistance toward this request?
The chain id's detail on ethereum-list:master still didn't have any update on it

@ligi ligi reopened this Jan 14, 2023
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tl;dr: it is now required to put the binary icon into iconDownload

why: it was a PITA to always ipfs get in the review process - sometimes it takes really long or even fails (especially with pinata) - this took significant time (which adds up with the amount of chains added) and slowed down the review process. Also sometimes CIDs become unavailable after - big mess. Hence it is now required to put them in iconDownload (still named via CID)

@ligi ligi mentioned this pull request Jan 14, 2023
@dcnl1980
Copy link
Contributor

Chain Id 96 is already in use for next smart chain, it will conflict. You can use another chain id for the mainnet.

@dcnl1980
Copy link
Contributor

Before next smart chain we run on another blockchain which is even older. I will send proof of this genesis block.

@ligi
Copy link
Member

ligi commented Jan 14, 2023

Before next smart chain we run on another blockchain which is even older. I will send proof of this genesis block.

this would help - then this is likely not to be merged here - except for the Testnet - @ppanya - please split in this case

@macvts
Copy link
Contributor

macvts commented Jan 14, 2023

would like @dcnl1980 to share the proof of genesis block here so thats can be right for @ligi to consider in this case.

Some of my opinion: if there is another blockchain with older genesis block using chain id 96, isn't it need to change into that name of the blockchain?

tbh if chain id 96 will be submitted as a NEXT Smart Chain, Bitkub Chain has the right to claim this due to the older genesis block.

@macvts
Copy link
Contributor

macvts commented Jan 14, 2023

on top of that, next smart chain currently have around 25.9K blocks with 5,342 transactions while Bitkub Chain exceeded 10M blocks with total transaction of 339M as of now.

Isn't it suitable for NEXT Smart Chain to be the one who change the chain ID?

for comparison:
www.bkcscan.com
https://explorer.nextsmartchain.com

@macvts
Copy link
Contributor

macvts commented Jan 16, 2023

@ligi gentle follow-up for your consideration to this case

@ppanya ppanya changed the title Add Bitkub Chain Mainnet and Testnet Add Bitkub Chain Mainnet Jan 16, 2023
@ppanya ppanya changed the title Add Bitkub Chain Mainnet Add Bitkubchain Mainnet Jan 16, 2023
@macvts macvts mentioned this pull request Jan 16, 2023
@ligi
Copy link
Member

ligi commented Jan 16, 2023

@dcnl1980 plese send the proof - otherwise I need to merge this one (but it for sure needs "redFlags": ["reusedChainId"] then)
I give you 7 days to respond - otherwise it will be merged (with redFlags)

@dcnl1980
Copy link
Contributor

@ligi Proof will be send later today.

@dcnl1980
Copy link
Contributor

@ligi Proof will be send later today.

In the attachment you find the proof of the old blockchain, which we run before NEXT Smart Chain and which have the same Chain ID 96.

The genesis block was mined with timestamp 1555502400, which is Wed Apr 17 2019 12:00:00 GMT+0000.

NEXT itself has been active in the market since October 2017.

on top of that, next smart chain currently have around 25.9K blocks with 5,342 transactions while Bitkub Chain exceeded 10M blocks with total transaction of 339M as of now.

Regarding the above I want to object that the amount of blocks or transactions per blockchain can be different, the old NEXT Chain had over 1,8M blocks, but the new NEXT Smart Chain (more efficient) only creates blocks when transactions are actually performed and not every few seconds like BitKub does.

Thinking in solutions. I have no problem with both names being listed under Chain ID 96 (if possible). It would solve both problems. Changing a chain ID for a running public and operative blockchain is almost impossible without starting a new one.

screenshot-16012023105512

@macvts
Copy link
Contributor

macvts commented Jan 16, 2023

I'm not quite sure if the proof you provide is valid or not, is it right to use this proof of old blockchain (inactive or currently active?) as an authority to chain id 96 is not suitable at all as I mentioned in my thought above.

Also speaking of the discussion on the genesis block on the current NEXT Smart Chain, we didn't ask for NSC to change your chain ID as you said before but we only need the right the be presenting as the only blockchain on chain ID 96 user's search

@ligi please considerately suggest in this case whether it's right to use the old blockchain genesis block (which is unknown for the current status) to claim the authority to represent the new chain which is younger than Bitkub Chain.

@ligi
Copy link
Member

ligi commented Jan 16, 2023

@ppanya please add "redFlags": ["reusedChainId"]
@dcnl1980 unfortunately this is not really a proof and could be crafted - so I think I have to go with merging as for our collision management policy. Why didn't you choose a new chainID back then? This would have been much better (also wrt replay attacks)

@dcnl1980
Copy link
Contributor

dcnl1980 commented Jan 16, 2023

@ligi why this should not be a proof, this block chain is still active and much older than Bitkub, so we should overrule them.

We even did not know the existence of Bitkub when we choose the chain is, why we should if we have older rights? We checked your website and 96 was available.

We could also turn it around, why Bitkub did not register it 2 years ago?

Anyway we are not agreeing, where can we make objection about this?

@ligi
Copy link
Member

ligi commented Jan 23, 2023

I do not think it is enough proof yet - this screenshot is trivial to create. Doing a chain with blockexplorer is at least a bit harder - but yea I know it can also easily be faked (at least for non PoW chains) - but so could the other chain be.

But to not be in the situation again I now changing the policy:

#1629

@dcnl1980
Copy link
Contributor

dcnl1980 commented Jan 23, 2023

I think it's good to change the policy, to first come, first serve, like domain names. We did our research but it's impossible to find another blockchain which was using chain id 96. Now it appears that somebody else is using it also and this is making big issues. I also understand that you don't think it's enough proof yet, but if we put our block explorer online, it will be a total different story. If needed we will do, since we refuse that somebody else is claiming chain ID 96. We deployed this old chain years ago. If we need to overrule BitKub, we will, but it don't need to end up into a fight. Also they are using NEXT in their Bitkub NEXT, which we already release in 2017. I see them as a copycat in this case. So can you agree with it, if we proof and launch our blockchain explorer, a serious issue will appear? In this case, are you agree that we will takeover chain ID 96 again?

@ligi
Copy link
Member

ligi commented Jan 23, 2023

After Explorer and RPC stand the trial of some tests I will close this PR

@dcnl1980
Copy link
Contributor

Got it, but this was the previous blockchain after it was merged to another one. So we need time to put the old explorer online (since we take it offline). Anyway you can push Bitkub further. In a later stage I will come back to overrule them by this older blockchain. In that case I want to make sure that it will not make any issue. This change will be just temporary.

@macvts
Copy link
Contributor

macvts commented Jan 23, 2023

May I ask for the estimate time of merging this PR?

Still disagree from the very start that using the old blockchain to claim the authority while the actual use is the new one while comparing to ours are older, with current state of situation is totally unacceptable to bring that up.

Also just want to clarify that the performance and reliability stays in the blockchain, its all provable whether for total wallet address, numbers of project, and numerous partners with bitkub.

@dcnl1980
Copy link
Contributor

@macvts make it clear. We have all the right to bring the old blockchain up. You had to register it a long time ago. You awake after 2 years to claim chain id 96, while we are in the market since 2017, that is a fact. You also called it Bitkub NEXT, so it can be also a trade mark issue as well. Our blockchain will overrule the one which you have if we put the explorer online. You have no right to take chain 96 at all. You are trying to suggest that your blockchain have more transactions, but that is also not a valid proof. Reject this Bitkub thing, on the first serve, first come. We are already in the market since 2017. It is not our mistake that Bitkub comes with a claim after several years.

@macvts
Copy link
Contributor

macvts commented Jan 23, 2023

while we are in the market since 2017, that is a fact.

on the other side of your fact, NSC is the one who starts splitting into new blockchain to restart the whole structure (younger genesis block) which you should be aware of the collision policy that the oldest genesis block will have the authority toward the chain ID 96 and now you resisting while trying to use your no-use blockchain (or maybe unknown) to claim the authority instead. FYI @ligi

currently to the case, we're considering while the policy with the oldest to win and some info that might be useful before any slander to anyone with a trademark issue @dcnl1980
Bitkub Chain = blockchain
Bitkub NEXT = Digital Wallet Service Provider
Bitkub Exchange = Crypto Exchange
Bitkub Venture = Venture Capital
Bitkub Academy = Educational Hub for Crypto Trader

@dcnl1980
Copy link
Contributor

@macvts we have the rights to upgrade our blockchain, I don’t see any issues in that. Even with our older blockchain (which is still operational and in use) we are much older than BitKub.

@macvts
Copy link
Contributor

macvts commented Jan 23, 2023

any upgrade (or hardfork) while shifting the data from the old blockchain ≠ splitting to the new blockchain where you choose to start a new one (with the same Chain ID) I'd rather not debate to make ligi feel more suffer to this situation and will looking forward to the decision and willing to accept this with the policy (oldest genesis win) that we'd been starting on the discussion here.

I and Bitkub Chain Team hope this PR will be considered to be merged since we also quietly wait for NSC to prove themselves for a week and they're not responding until we follow things up and to finish off this policy afterward. 🙇🏻‍♂️

@ligi
Copy link
Member

ligi commented Jan 25, 2023

I am very much leaning this way after thinking about it for a while:

image

https://twitter.com/danfinlay/status/1617597043949830144

@macvts
Copy link
Contributor

macvts commented Jan 25, 2023

will totally respect your decision, I also hope somehow that this could be work for Bitkub Chain since we never go against any rule or cause any issue from the very beginning.

@macvts
Copy link
Contributor

macvts commented Feb 6, 2023

I will very likely merge this soon - seems the current policy and arguments are on your side - but first I really need to change the policy. Never want to be in this situation again.

After Explorer and RPC stand the trial of some tests I will close this PR

Gentle follow-up for the direction of the case, I genuinely provide a total of 3 weeks for NSC to provide proof to support their authority. probably want this to be fairly considered from the beginning of the discussion with the past policy that just recently changed due to the confliction of this case. @ligi

@dcnl1980
Copy link
Contributor

dcnl1980 commented Feb 6, 2023

Not sure what the issue is. We are still the oldest chain for over a few years. It is not our issue that BitKub did not register their ChainID on time. We check your website and it was available.

Secondary we are still the old blockchain which can overrule BitKub by being the oldest. This chain is still online and if needed we will release the explorer to prove it, but it will take some time, since the old chain is depreciated.

So I would like to make sure and agree with you that we can claim this id, if we are the oldest chain, not that you are changing the rules in between. At all we will not change our id at all and keep running on chain id 96.

ligi added a commit that referenced this pull request Feb 8, 2023
@ligi ligi mentioned this pull request Feb 8, 2023
@ligi
Copy link
Member

ligi commented Feb 8, 2023

@dcnl1980 so far you did not provide proof - you where asked to provide provide explorer and RPC multiple times - and you did not.
I think the best is to go with Dan Finlays suggestion and just remove the chain
PR #2251 opened - will likely be merged soon
You can then add back your old chain if you want.
I think this is the safest option for users while still following the policy from this time.

@dcnl1980
Copy link
Contributor

dcnl1980 commented Feb 8, 2023

@dcnl1980 so far you did not provide proof - you where asked to provide provide explorer and RPC multiple times - and you did not.
I think the best is to go with Dan Finlays suggestion and just remove the chain
PR #2251 opened - will likely be merged soon
You can then add back your old chain if you want.
I think this is the safest option for users while still following the policy from this time.

as already stated, the current blockchain is an update of a much older blockchain (older than BitKub) which is set to chain id 96, however this old blockchain is still operational.

As mentioned by you I will reserve the right to claim chain id 96 in a later stage, when the RPC and explorer are online.

@ligi
Copy link
Member

ligi commented Feb 8, 2023

Wondering how the old chain is still operational when you cannot provide me with an RPC. If the chain is still operational it should not take long to just expose an RPC of a node.
Also wonder what you where thinking reusing a chainID for something that does not seem to be just a TestNet - how do you protect your users from replay attack?

@dcnl1980
Copy link
Contributor

dcnl1980 commented Feb 8, 2023

Wondering how the old chain is still operational when you cannot provide me with an RPC. If the chain is still operational it should not take long to just expose an RPC of a node.
Also wonder what you where thinking reusing a chainID for something that does not seem to be just a TestNet - how do you protect your users from replay attack?

We disable the public RPC and explorer, but there are still miners active on this network which are directly connected on their own RPC node interface.

A reply attack is not possible, each blockchain have another consensus protocol. We choose to continue with the chain id since we defined it before in the genesis file and it is most logical since our customers are connected to it with their clients.

Anyway we hoped we did not had to open the public rpc and explorer again, but we are forced to do so. I asked the devs to put it back, after that is done, I will come back to claim chain id 96.

@ligi
Copy link
Member

ligi commented Feb 8, 2023

A reply attack is not possible, each blockchain have another consensus protocol.

how exactly does the consensus protocol change prevent replay attacks?

ligi added a commit that referenced this pull request Feb 14, 2023
@ligi
Copy link
Member

ligi commented Feb 14, 2023

I just merged #2251 - @dcnl1980 you might re-add your old chain answering above question and provide RPC/explorer for the old one.

@macvts
Copy link
Contributor

macvts commented Feb 15, 2023

will this PR be considered in any scenario in the future? or @ligi will only wait for their answer to re-add or no one get this chain ID?

@ligi
Copy link
Member

ligi commented Feb 19, 2023

yea - will likely be merged as @dcnl1980 is not answering anymore - so seems the case is leaning on your side now. But u need to rebase or merge to master

@ligi ligi merged commit 5038dbe into ethereum-lists:master Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants