fix(docs): replace dead privacy.md link with GitHub URL#7641
Merged
JohnMcLear merged 1 commit intodevelopfrom May 1, 2026
Merged
fix(docs): replace dead privacy.md link with GitHub URL#7641JohnMcLear merged 1 commit intodevelopfrom
JohnMcLear merged 1 commit intodevelopfrom
Conversation
PR #7546 added a relative link in `doc/privacy.md` pointing to `../docs/superpowers/specs/2026-04-18-gdpr-pr1-deletion-controls-design.md`, which lives outside vitepress's `doc/` source root. VitePress reports it as a dead link and the docs deploy on develop fails: (!) Found dead link ./../docs/superpowers/specs/2026-04-18-gdpr-pr1-deletion-controls-design in file /home/runner/work/etherpad/etherpad/doc/privacy.md Error: 1 dead link(s) found. Point the link at the file on GitHub instead so the published site resolves it and readers can still find the spec. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
Review Summary by QodoFix dead link in privacy.md by pointing to GitHub URL
WalkthroughsDescription• Replace relative link to spec file with GitHub URL • Resolves VitePress dead link detection failure • Enables docs deployment workflow to succeed Diagramflowchart LR
A["Relative link<br/>../docs/superpowers/specs/..."] -->|"Replace with"| B["GitHub URL<br/>github.com/ether/etherpad/blob/develop/..."]
B -->|"Result"| C["VitePress validation passes<br/>Docs deploy succeeds"]
File Changes1. doc/privacy.md
|
Code Review by Qodo
1. Hardcoded https://github.com link
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doc/privacy.mdto../docs/superpowers/specs/2026-04-18-gdpr-pr1-deletion-controls-design.md. That spec file lives outside vitepress'sdoc/source root, so VitePress flags it as a dead link and the Deploy Docs to GitHub Pages workflow on develop fails:Test plan
pnpm run docs:buildsucceeds locally (build complete in 2.29s)🤖 Generated with Claude Code