Skip to content

ci: force qodo to check PR desc #7346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnMcLear merged 1 commit into from
Mar 4, 2026
+2 −0
Merged

ci: force qodo to check PR desc #7346

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions best_practices.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@

## Pull requests

* PRs MUST include a non-empty description explaining what the change does and why
* PRs without a description should be flagged as incomplete
Comment on lines +8 to +9
Copy link
Copy Markdown

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. No enforcement implemented 🐞 Bug ✓ Correctness

Despite the PR title/description implying a CI/qodo check, the change only adds documentation text
and does not implement any repository-side enforcement. As a result, PRs with empty descriptions
will not be automatically flagged by this repo’s CI based on this change alone.
Agent Prompt 
## Issue description
The PR claims to “force qodo to check PR desc”, but only adds documentation bullets. If the goal is enforcement, a repo-local check (CI) needs to be added; otherwise the PR’s stated intent is misleading.

## Issue Context
The requirement is currently only expressed as text in `best_practices.md`.

## Fix Focus Areas
- best_practices.md[6-12]
- .github/workflows/* (add a new workflow to validate PR description, or adjust existing workflow set accordingly)

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

* the commit series in the PR should be _linear_ (it **should not contain merge commits**). This is necessary because we want to be able to [bisect](https://en.wikipedia.org/wiki/Bisection_(software_engineering)) bugs easily. Rewrite history/perform a rebase if necessary
* PRs should be issued against the **develop** branch: we never pull directly into **master**
* PRs **should not have conflicts** with develop. If there are, please resolve them rebasing and force-pushing
Expand Down
Loading