Skip to content

introduce client side hook goToRevisionEvent #3757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muxator merged 5 commits into from
Mar 24, 2020
Merged

introduce client side hook goToRevisionEvent #3757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9ea5ad9
Merge pull request #2 from ether/develop
JohnMcLear Mar 15, 2020
c696165
Merge pull request #3 from ether/develop
JohnMcLear Mar 17, 2020
a59d48c
Merge pull request #4 from ether/develop
JohnMcLear Mar 21, 2020
0cf1692
Merge branch 'develop' of github.com:ether/etherpad-lite into develop
JohnMcLear Mar 23, 2020
b4bf8ba
hooks: introduce goToRevisionEvent(), a new client-side hook
JohnMcLear Mar 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions doc/api/hooks_client-side.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,16 @@ Called from: src/static/js/timeslider.js

There doesn't appear to be any example available of this particular hook being used, but it gets fired after the timeslider is all set up.

## goToRevisionEvent
Called from: src/static/js/broadcast.js

Things in context:

1. rev - The newRevision

This hook gets fired both on timeslider load (as timeslider shows a new revision) and when the new revision is showed to a user.
There doesn't appear to be any example available of this particular hook being used.

## userJoinOrUpdate
Called from: src/static/js/pad_userlist.js

Expand Down
5 changes: 5 additions & 0 deletions src/static/js/broadcast.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,6 +336,11 @@ function loadBroadcastJS(socket, sendSocketMsg, fireWhenAllScriptsAreLoaded, Bro
var self = this;
var path = revisionInfo.getPath(padContents.currentRevision, newRevision);
debugLog('newRev: ', padContents.currentRevision, path);

hooks.aCallAll('goToRevisionEvent', {
rev: newRevision
});

if (path.status == 'complete')
{
var cs = path.changesets;
Expand Down