Skip to content

fix for infinite loop on bad changeset#2089

Merged
JohnMcLear merged 1 commit intoether:developfrom
dmitryuv:changesetslib-fixes
Mar 13, 2014
Merged

fix for infinite loop on bad changeset#2089
JohnMcLear merged 1 commit intoether:developfrom
dmitryuv:changesetslib-fixes

Conversation

@dmitryuv
Copy link
Copy Markdown
Contributor

In case pad state is broken, or bad changeset somehow was submitted to the store, this check is required to avoid infinite loop in the consuming code.

@marcelklehr
Copy link
Copy Markdown
Contributor

Will need some testing

@marcelklehr marcelklehr mentioned this pull request Feb 26, 2014
8 tasks
@dmitryuv
Copy link
Copy Markdown
Contributor Author

@marcelklehr interested in 50% performance improvement for v8 with the changesets library? can make another pull request, but it changes a lot (mainly closures->prototype classes and removal of outdated "optimizations")

@marcelklehr
Copy link
Copy Markdown
Contributor

hoh! sounds interesting, will the exposed module API change?

@JohnMcLear
Copy link
Copy Markdown
Member

Does it break any functionality at all? So far sounds good :) thanks dmitry and in general very pleased you are finding the time and energy to contribute, we appreciate it!

@dmitryuv
Copy link
Copy Markdown
Contributor Author

@marcelklehr no it don't, API is the same. It's just cosmetic code changes here and there, not "deep refactoring". Everything else is the same. I'll test more with real data and make pull request if everything works fine. Tests are running fine too, but i'm not sure they cover everything.

@JohnMcLear
Copy link
Copy Markdown
Member

@marcelklehr you happy for this to be merged?

@marcelklehr
Copy link
Copy Markdown
Contributor

I barely glanced at this change, it looks like it makes sense. Basic
editing seems to work. It would of course be helpful to have a test case
that fails in the old version and passes with this change.

If it works for dmitry, I guess we can just pull it.

JohnMcLear added a commit that referenced this pull request Mar 13, 2014
fix for infinite loop on bad changeset
@JohnMcLear JohnMcLear merged commit cc03f53 into ether:develop Mar 13, 2014
@dmitryuv dmitryuv deleted the changesetslib-fixes branch March 14, 2014 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants