Skip to content

Dont pass padid in historical authors #1921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnMcLear merged 2 commits into from
Oct 6, 2013
Merged

Dont pass padid in historical authors #1921

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b32aaae
do not pass historical author data to read only users
JohnMcLear Oct 6, 2013
d708803
remove white space
JohnMcLear Oct 6, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/node/handler/PadMessageHandler.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1016,6 +1016,10 @@ function handleClientReady(client, message)
// Warning: never ever send padIds.padId to the client. If the
// client is read only you would open a security hole 1 swedish
// mile wide...
// Heh, turns out we already did when we sent historicalAuthorData so
// if it's a readonly pad request don't send the pad IDs of the author
if(sessioninfos[client.id].readonly) historicalAuthorData = {};

var clientVars = {
"accountPrivs": {
"maxRevisions": 100
Expand Down