Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIGTERM not honoured #3265

Closed
Rillke opened this issue Oct 16, 2017 · 0 comments
Closed

SIGTERM not honoured #3265

Rillke opened this issue Oct 16, 2017 · 0 comments

Comments

@Rillke
Copy link
Contributor

Rillke commented Oct 16, 2017 •
edited
Loading

Etherpad ignores SIGTERM. It processes SIGINT signal. This potentially causes an unexpected loss of data or data corruption when used with Docker as PID 1 and makes the shutdown unnecessarily slow.

  • host os and version: https://github.com/tvelocity/dockerfiles/tree/master/etherpad-lite (Debian GNU/Linux 8 (jessie), ETHERPAD_VERSION 1.6.1, nodeJS=v7.6.0)
  • steps to reproduce: docker stop etherpad
  • what you expected to happen: Graceful shutdown
  • what actually happened: Graceful shutdown time times out and container (the nodeJS process) is shut down forcefully by SIGKILL. Outgoing database connections and incoming client connections can't be gracefully closed. Internal buffers might not be written to disk (don't know whether this is an issue here, not an Etherpad insider).

C.f.
This was referenced Oct 16, 2017
Closed
Merged
lpagliari pushed a commit that referenced this issue Nov 4, 2017
@Rillke @lpagliari
Catch SIGTERM for graceful shutdown (#3266)
f12debd 
Shut down database connection and exit the node process
when SIGTERM is encountered. This is especially important
when nodejs is run as PID1, e.g. in a docker container.

Shutting down connections to clients (browsers) is beyond
this patche's scope.

Resolves #3265
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Rillke