a11y: mark <select> aria-label as html10n-managed (forward-compatible)#138
Merged
Conversation
ether/etherpad#7713 extends html10n's aria-label auto-population to cover form-control elements (<select>, <input>, <textarea>). On newer etherpad with that fix, html10n overwrites aria-label with the localized translation when the data-l10n-aria-label="true" marker is present. Adds the marker (and keeps the existing hardcoded aria-label) so: - older etherpad without the html10n fix: aria-label remains the hardcoded English fallback (no regression); - newer etherpad with the html10n fix: aria-label gets the localized translation, refreshed on pad.applyLanguage(). Also drops the no-op data-l10n-attr="aria-label" attribute (etherpad's html10n doesn't read it; that's a convention from a different localization library).
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
data-l10n-aria-label="true"to toolbar<select>elements withdata-l10n-id. After ether/etherpad#7713, html10n's aria-label auto-population covers form-control elements; the marker tells html10n it owns this attribute and may overwrite it with the localized string on everypad.applyLanguage()call.Forward-compatible, not a breaking change for users on older etherpad:
aria-labelremains as a fallback (no regression).Also drops
data-l10n-attr="aria-label"— a no-op convention from a different localization library.