-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Call for Input: Adding Additional Author to ERC-5169 #308
Comments
but why? again authors is not the credit list and we shouldnt treat it like that. so unless it needs maintenance which it does not I vote NO |
Final is final, I vote no (but don't have a vote). There shouldn't be changes after an ERC is final, it is too late to add an author. They can do credits elsewhere e.g. on a website for the ERC. |
@JamesSmartCell, could you state your justification here? We haven't had precedents for adding an author after finalization, nor do we have precedents for rejecting a request to add an author; hence, I think it's worthy of a discussion. Also, can you join the EIPIP meeting next Wednesday? That would be a good venue to make your case before the editors. |
I vote no |
i'd rather PR EIP-1 to make the semantic of |
@gcolvin feels pretty strongly that I'm assuming that means he's for merging this PR. |
For my part, @g11tech convinced me with this argument, roughly quoted:
I am against adding a new author. |
The prevailing opinion is to not modify a final EIP. |
I disagree, @g11tech. I suggest you ask the Duck or the Google about "authorship credit." This is an Errata. I've added the need for an Errata section to the next meeting agenda. |
Hopefully I noted your objection correctly in #308 (comment). |
Yes, you have. And I'm pointing out that it's not just my own opinion. We can discuss it on the Agenda issue. #312 |
Call for Input
Do we merge ethereum/ERCs#184 ?
@CharlesFus is added as an author to ERC-5169 (Final.)
Background
@JamesSmartCell (an original author of ERC-5169) would like to add @CharlesFus as an author. ERC-5169 is final.
The text was updated successfully, but these errors were encountered: