Fix: pass min_required_proofs as a parameter #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Dec 21, 2025
| } | ||
|
|
||
| /// Returns the minimum number of execution proofs required for a block at the given epoch. | ||
| /// Returns `None` if proofs are not required (zkVM not enabled for this epoch). |
Author
There was a problem hiding this comment.
Does not check proof boundary epoch/retention window since that will be done on the sync layer
kevaundray
commented
Dec 21, 2025
Comment on lines
+610
to
+611
| None, | ||
| min_proofs_required_opt, |
Author
There was a problem hiding this comment.
This means we could have execution proofs, pre-peerDAS -- we can make this stricter/remove this later on if we feel it doesn't help with testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Which issue # does this PR address?
Proposed Changes
Please list or describe the changes introduced by this PR.
Additional Info
Please provide any additional information. For example, future considerations
or information useful for reviewers.