Remove proof generation type node #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- check for zkvm capability in the enr - execution_proof_lookup_request filters zkvm nodes
kevaundray
commented
Dec 14, 2025
Comment on lines
-152
to
-153
| #[test] | ||
| fn test_proof_lookup_unrequested_proof() { |
Author
There was a problem hiding this comment.
Remove tests like this, all zkvm enabled nodes will have historical proofs moving forward
kevaundray
commented
Dec 14, 2025
Comment on lines
+1138
to
+1139
| // Expect peer to provide all requested proofs - if they can't, penalize | ||
| true, |
kevaundray
commented
Dec 14, 2025
beacon_node/http_api/src/lib.rs
Outdated
| }) | ||
| }, | ||
| ); | ||
| // TODO(zkproofs): I think we want to return a block_with_witness |
Author
There was a problem hiding this comment.
Here block refers to EL block -- okay given it merges with verkle stateless abstraction
kevaundray
commented
Dec 14, 2025
Comment on lines
+533
to
+534
| pub fn post_beacon_pool_execution_proofs<T: BeaconChainTypes>( | ||
| network_tx_filter: &NetworkTxFilter<T>, |
Author
There was a problem hiding this comment.
should be protected similar to when one is posting a block
kevaundray
commented
Dec 14, 2025
Comment on lines
+572
to
+573
| // Proof is valid but was received via non-gossip source | ||
| // It's in the DA checker, so we should publish it to gossip |
Author
There was a problem hiding this comment.
Note: Reaching this branch won't get it published via gossip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.