Skip to content

params: ECIP1088 feature activation numbers#48

Merged
meowsbits merged 2 commits into
masterfrom
feat/ecip1088-configs
Mar 2, 2020
Merged

params: ECIP1088 feature activation numbers#48
meowsbits merged 2 commits into
masterfrom
feat/ecip1088-configs

Conversation

@meowsbits
Copy link
Copy Markdown
Contributor

https://github.com/ethereumclassic/ECIPs/blob/master/_specs/ecip-1088.md

The block numbers for Mordor and Kotti are still, AFAIU, somewhat unstable.

These initially proposed numbers (at cf93f23) are taken from investigation via #38 to find the latest-viable numbers the chains can reach before the now-nullified Aztlan features would fork the networks.

Signed-off-by: meows <b5c6@protonmail.com>
Copy link
Copy Markdown
Contributor

@q9f q9f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix the testnet block numbers according to the ecip 1088

https://ecips.ethereumclassic.org/ECIPs/ecip-1088

Comment thread params/config_mordor.go Outdated
Comment thread params/config_kotti.go Outdated
@q9f
Copy link
Copy Markdown
Contributor

q9f commented Feb 28, 2020

ref ChainSafe/besu#26

Signed-off-by: meows <b5c6@protonmail.com>
@meowsbits meowsbits marked this pull request as ready for review February 28, 2020 12:01
Copy link
Copy Markdown
Contributor

@tzdybal tzdybal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numbers are matching ECIP.

Copy link
Copy Markdown
Contributor

@q9f q9f left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

Tested on Mordor on block 945_xxx this morning.

Mordor will fork in 7-14 days if the head stabilizes.

@q9f
Copy link
Copy Markdown
Contributor

q9f commented Mar 2, 2020

To recover Kotti, I would wait for client releases

@meowsbits meowsbits merged commit b5c6984 into master Mar 2, 2020
@meowsbits meowsbits deleted the feat/ecip1088-configs branch March 2, 2020 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants