etcdserver: Fix v2v3api set to create parent directly if not exists #9626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Include a test? |
|
I think we should run the integration tests for the v2 api against the v2v3 emulated endpoint. I'll try to do so. |
|
@yudai Just simple unit test in Thanks! |
When a new file is created under an non existent directly, the v2 API automatically create the parent directly. This commit aligns the behaviour of v2v3 emulation to comply with the v2 API.
yudai
force-pushed
the
fix_set_inexist_dir
branch
from
1b62051
to
3c25465
Compare
|
@gyuho Thanks for the pointer. I added a unit test. |
|
Created a separate PR for integration test enhancement, because it can take some time to complete. |
gyuho
approved these changes
Apr 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new file is created under an non existent directly,
the v2 API automatically create the parent directly.
This commit aligns the behaviour of v2v3 emulation to comply with the v2
API.
Fixes #9609