Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated cherry pick of #9415 #9500

Merged

Conversation

jpbetz
Copy link
Contributor

@jpbetz jpbetz commented Mar 28, 2018

Cherry pick of #9415 on release-3.1.

#9415: rafthttp: add "ActivePeers" to "Transport"

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@jpbetz jpbetz mentioned this pull request Mar 28, 2018
25 tasks
@jpbetz jpbetz force-pushed the automated-cherry-pick-of-#9415-release-3.1 branch from 315e177 to 8eeab58 Compare March 28, 2018 17:17
@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 28, 2018

Fixed mistake merge conflict.

@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 28, 2018

Looks like there is some additional code that cannot be cleanly merged, semantically merging it manually now.

@gyuho
Copy link
Contributor

gyuho commented Mar 28, 2018

@jpbetz Yeah, could have been easier to cherry-pick individual commits or edit directly in the branch :0

This is missing adjustTicks https://github.com/coreos/etcd/pull/9415/files#diff-971f6af906b31cc86efd71aff56aa96bR533?

@jpbetz
Copy link
Contributor Author

jpbetz commented Mar 28, 2018

@gyuho Yep, that auto-merge didn't work out. I've manually applied the changes that didn't auto merge. Everything should be in place now, but please double check me!

@jpbetz jpbetz merged commit 2a629a8 into etcd-io:release-3.1 Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants