Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: enforce max lease TTL with 9,000,000,000 seconds #9399

Merged
merged 3 commits into from
Mar 8, 2018

Conversation

yudai
Copy link
Contributor

@yudai yudai commented Mar 8, 2018

math.MaxInt64 / time.Second is 9,223,372,036. 9,000,000,000 is easier to
remember/document.

Closes #9374.

@yudai
Copy link
Contributor Author

yudai commented Mar 8, 2018

Do we need to copy the same value to the clientv3 package, so that client users can access the value easier?

@gyuho
Copy link
Contributor

gyuho commented Mar 8, 2018

@yudai Sure. I would rename https://github.com/coreos/etcd/blob/master/clientv3/grpc_options.go to options.go, and define there as a constant?

@gyuho
Copy link
Contributor

gyuho commented Mar 8, 2018

@yudai
Copy link
Contributor Author

yudai commented Mar 8, 2018

@gyuho done!

@gyuho gyuho mentioned this pull request Mar 8, 2018
25 tasks
@gyuho
Copy link
Contributor

gyuho commented Mar 8, 2018

@yudai Thanks! I will merge this by today.

Iwasaki Yudai and others added 3 commits March 8, 2018 10:17
math.MaxInt64 / time.Second is 9,223,372,036. 9,000,000,000 is easier to
remember/document.
@gyuho gyuho merged commit 6fd4138 into etcd-io:master Mar 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants