embed: explicitly define unix proto#9354
Conversation
|
Upstream grpc-go fixes will be merged next week allowing unix support to work. |
b75a018 to
887518c
Compare
|
@gyuho PTAL. |
I need to understand how this can happen, seems like tests are not using patched grpc-go. |
|
@hexfusion etcd master still uses old gRPC, so we may see it for awhile :0 Also we need to wait until we upgrade gRPC in master branch including your fix on unix socket. |
| conn, err := grpc.DialContext(ctx, sctx.addr, opts...) | ||
|
|
||
| addr := sctx.addr | ||
| // explictly define unix network for gRPC socket support |
There was a problem hiding this comment.
Let's make it simpler?
if sctx.network == "unix" {
addr = fmt.Sprintf("%s://%s", network, addr)
}|
@gyuho anything else we need here? I plan on improving test coverage in another PR. Thanks! |
This is pending grpc/grpc-go#1883
ref: #9340