Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clientv3: backport new balancer to release-3.2, upgrade gRPC to v1.7.3 #8867

Merged
merged 10 commits into from
Nov 16, 2017

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Nov 13, 2017

Address #8854.

v3.2.9 has grpc/grpc-go v1.2.1 with Go 1.8.4.
v3.2.10 will require grpc/grpc-go v1.7.3 with Go 1.8.5.

Backporting all balancer fixes from master branch covering #8711 tests.

Compared to master branch, it still imports golang.org/x/net/context, and misses some new APIs(MovLeader, HashKV, LeaseLeases) and features(ordering, leasing, #8283).

I've highlighted this clientv3 + gRPC change in #8868.

Other dependency updates (grpc-gateway, proto, etc.) were required to deprecate other components in gRPC (e.g. metadata.NewContext).

Also some additional changes in server side to support new gRPC versions (e.g. #8437).

@gyuho gyuho added the WIP label Nov 13, 2017
@gyuho gyuho force-pushed the clientv3-backport-to-release-3.2 branch from d1a9ab3 to 7162cf8 Compare November 13, 2017 20:40
@gyuho gyuho removed the WIP label Nov 13, 2017
@gyuho gyuho force-pushed the clientv3-backport-to-release-3.2 branch from b4448c7 to 373046a Compare November 13, 2017 21:53
@gyuho gyuho force-pushed the clientv3-backport-to-release-3.2 branch 13 times, most recently from df6e953 to 3695871 Compare November 14, 2017 03:19
@gyuho gyuho removed the WIP label Nov 14, 2017
@gyuho gyuho force-pushed the clientv3-backport-to-release-3.2 branch 2 times, most recently from 6365b3f to 23171a3 Compare November 14, 2017 04:28
@gyuho gyuho added the WIP label Nov 15, 2017
@gyuho gyuho closed this Nov 16, 2017
@gyuho gyuho deleted the clientv3-backport-to-release-3.2 branch November 16, 2017 17:05
@gyuho gyuho restored the clientv3-backport-to-release-3.2 branch November 16, 2017 17:14
@gyuho gyuho reopened this Nov 16, 2017
@gyuho gyuho force-pushed the clientv3-backport-to-release-3.2 branch from 23171a3 to 7bd8717 Compare November 16, 2017 17:28
It was fatal-ing with:

grpclog.Fatalf("grpc: Server.RegisterService after Server.Serve for %q", sd.ServiceName)

Signed-off-by: Gyu-Ho Lee <[email protected]>
@gyuho gyuho force-pushed the clientv3-backport-to-release-3.2 branch from 7bd8717 to 91335d0 Compare November 16, 2017 17:34
@gyuho gyuho changed the title clientv3: backport new balancer to release-3.2, upgrade gRPC to v1.7.x clientv3: backport new balancer to release-3.2, upgrade gRPC to v1.7.3 Nov 16, 2017
@gyuho gyuho removed the WIP label Nov 16, 2017
@gyuho gyuho requested a review from xiang90 November 16, 2017 17:59
@xiang90
Copy link
Contributor

xiang90 commented Nov 16, 2017

lgtm

@gyuho gyuho merged commit 3039c63 into etcd-io:release-3.2 Nov 16, 2017
@gyuho gyuho deleted the clientv3-backport-to-release-3.2 branch November 16, 2017 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants