clientv3: backport new balancer to release-3.2, upgrade gRPC to v1.7.3 #8867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
force-pushed
the
clientv3-backport-to-release-3.2
branch
from
d1a9ab3
to
7162cf8
Compare
gyuho
force-pushed
the
clientv3-backport-to-release-3.2
branch
from
b4448c7
to
373046a
Compare
gyuho
force-pushed
the
clientv3-backport-to-release-3.2
branch
13 times, most recently
from
df6e953
to
3695871
Compare
gyuho
force-pushed
the
clientv3-backport-to-release-3.2
branch
2 times, most recently
from
6365b3f
to
23171a3
Compare
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
…integration Signed-off-by: Gyu-Ho Lee <[email protected]>
Signed-off-by: Gyu-Ho Lee <[email protected]>
gyuho
force-pushed
the
clientv3-backport-to-release-3.2
branch
from
23171a3
to
7bd8717
Compare
It was fatal-ing with:
grpclog.Fatalf("grpc: Server.RegisterService after Server.Serve for %q", sd.ServiceName)
Signed-off-by: Gyu-Ho Lee <[email protected]>
gyuho
force-pushed
the
clientv3-backport-to-release-3.2
branch
from
7bd8717
to
91335d0
Compare
gyuho
changed the title
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #8854.
v3.2.9 has grpc/grpc-go v1.2.1 with Go 1.8.4.
v3.2.10 will require grpc/grpc-go v1.7.3 with Go 1.8.5.
Backporting all balancer fixes from master branch covering #8711 tests.
Compared to master branch, it still imports
golang.org/x/net/context, and misses some new APIs(MovLeader,HashKV,LeaseLeases) and features(ordering,leasing, #8283).I've highlighted this clientv3 + gRPC change in #8868.
Other dependency updates (grpc-gateway, proto, etc.) were required to deprecate other components in gRPC (e.g.
metadata.NewContext).Also some additional changes in server side to support new gRPC versions (e.g. #8437).