clientv3/integration: add more tests on balancer switch, inflight range #8841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
force-pushed
the
test-test
branch
2 times, most recently
from
4c209a2
to
4de69ba
Compare
xiang90
reviewed
Nov 10, 2017
| // the client can switch to other available eps | ||
| cli.SetEndpoints(eps...) | ||
|
|
||
| if stopPinFirst { |
There was a problem hiding this comment.
If we stop pinned one first, balancer is expected to switch out of pinned address.
If we stop unpinned one, balancer won't do anything.
With these changes, now we can both cases.
xiang90
reviewed
Nov 10, 2017
| } | ||
| }() | ||
|
|
||
| time.Sleep(500 * time.Millisecond) |
There was a problem hiding this comment.
why do we need to sleep there?
There was a problem hiding this comment.
Original tests were testing inflight range requests.
gyuho
force-pushed
the
test-test
branch
8 times, most recently
from
3c89a40
to
c021e26
Compare
gyuho
force-pushed
the
test-test
branch
3 times, most recently
from
96cd8ac
to
6328bc5
Compare
Test all possible cases of server shutdown with inflight range requests. Removed redundant tests in kv_test.go. Signed-off-by: Gyu-Ho Lee <[email protected]>
|
Merging this to test new gRPC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test all possible cases of server shutdown with inflight range requests.
Removed redundant tests in kv_test.go.
c.f. #8711