Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clientv3: Add LeaseValue helper to Cmp LeaseID values in Txn #8488

Merged
merged 1 commit into from
Sep 5, 2017
Merged

clientv3: Add LeaseValue helper to Cmp LeaseID values in Txn #8488

merged 1 commit into from
Sep 5, 2017

Conversation

purpleidea
Copy link
Contributor

No description provided.

@purpleidea purpleidea mentioned this pull request Sep 1, 2017
Closed
@purpleidea
Copy link
Contributor Author

Fixes #8487

@purpleidea
Copy link
Contributor Author

jenkins-proxy-ci apparently failed due to:

/usr/local/go/pkg/tool/linux_amd64/link: flushing $WORK/github.com/coreos/etcd/integration/_test/integration.test: write $WORK/github.com/coreos/etcd/integration/_test/integration.test: no space left on device

That's out of my hands...

@purpleidea
Copy link
Contributor Author

@xiang90 @heyitsanthony Needs a review and a CI fix (infra broken) please.

heyitsanthony
heyitsanthony approved these changes Sep 5, 2017
View reviewed changes
Copy link
Contributor

@heyitsanthony heyitsanthony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for lack of a better name

please s/etcd:/clientv3:/ in the commit message since this affects the clientv3 package

@purpleidea
Copy link
Contributor Author

@heyitsanthony Commit message updated, and patch rebased to current git master.

@gyuho gyuho changed the title etcd: Add LeaseValue helper to Cmp LeaseID values in Txn clientv3: Add LeaseValue helper to Cmp LeaseID values in Txn Sep 5, 2017
gyuho
gyuho approved these changes Sep 5, 2017
View reviewed changes
Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@xiang90 xiang90 merged commit b1595f2 into etcd-io:master Sep 5, 2017
@purpleidea purpleidea deleted the feat/leaseid-helper branch October 20, 2017 05:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyitsanthony heyitsanthony heyitsanthony approved these changes

@gyuho gyuho gyuho approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@purpleidea @gyuho @heyitsanthony @xiang90