Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mvcc: set db size metric on restore #8120

Merged
merged 2 commits into from
Jun 16, 2017

Conversation

heyitsanthony
Copy link
Contributor

Fixes #8080

@xiang90
Copy link
Contributor

xiang90 commented Jun 16, 2017

lgtm

@xiang90
Copy link
Contributor

xiang90 commented Jun 16, 2017

even if there is nothing changed, we still close/reopen a txn every 100ms, right? i thought the db size should get updated at that time.

@heyitsanthony
Copy link
Contributor Author

@xiang90 it's an mvcc metric so the backend doesn't have any control over it; the mvcc code only sets the metric after processing a write

@heyitsanthony
Copy link
Contributor Author

failing on grpc/grpc-go#1316 and #5847. Jumping the gate and merging since this is low risk.

@heyitsanthony heyitsanthony merged commit e475a4e into etcd-io:master Jun 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants