embed: reject domain names before binding (again) #7236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm |
|
using this to kick the ppc64le CI; do not merge just yet |
heyitsanthony
force-pushed
the
no-dns-bind
branch
from
1c1c2ae
to
2c7242f
Compare
|
testing the comment trigger |
heyitsanthony
force-pushed
the
no-dns-bind
branch
2 times, most recently
from
d9791c3
to
5a67b0a
Compare
Current coverage is 64.20% (diff: 100%)
|
gyuho
added a commit
to gyuho/etcd
that referenced
this pull request
Dec 7, 2017
Address etcd-io#6336 (comment) about etcd-io#7236. Signed-off-by: Gyuho Lee <[email protected]>
gyuho
added a commit
to gyuho/etcd
that referenced
this pull request
Dec 8, 2017
Address etcd-io#6336 (comment) about etcd-io#7236. Signed-off-by: Gyuho Lee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6336 (again)