-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3: allow more ops in txns #5641
Conversation
context? |
ovs might want more ops in one txn. Applying a small op takes less than 50us in normal cases. Supporting 512 or even 1024 ops per txn is not a concern in my opinion. |
@xiang90 Sure, I'm mainly curious what the desired number of ops per txn would be for their use case. Is 1024 enough? |
@blp Can you provide more information here? Also for transnational read, etcd support consistent snapshot + pagination. You can do multiple txns over multiple keys on one consistent snapshot. |
@xiang90 It is really amazing that you submitted a pull request on the basis of a report on Twitter. Thank you very much! We are currently just trying to figure out whether etcd is suitable for our use case. We do not have a specific number yet. Since now I know that this limit is adjustable, I have enough information to continue investigating. I'll come back when I know more. |
FWIW I will have use cases which will hit 1024 ops. So I appreciate this feature, and would gladly welcome 1024 or more. When I have some production code demonstrating this we can always revisit and increase if needed, but this is a good start :) |
44ca396
to
4301f49
Compare
Superseded by #7976. Closing |
Awesome work! |
@blp
There is an additional txn number checking. Probably now we can make is larger since we already set the 1MB txn size limit.