-
Notifications
You must be signed in to change notification settings - Fork 10.2k
Document how to debug performance of Prow jobs in etcd #20796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ronaldngounou The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
eeca3a0 to
2e38276
Compare
2e38276 to
6d3c4f2
Compare
822a203 to
eb48c66
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #20796 +/- ##
==========================================
+ Coverage 69.12% 69.18% +0.06%
==========================================
Files 422 422
Lines 34826 34826
==========================================
+ Hits 24073 24095 +22
+ Misses 9352 9333 -19
+ Partials 1401 1398 -3 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Hi @ivanvc , could you please review? |
Please rebase |
|
Hi @ronaldngounou, there are a couple of broken links in the document you pushed. Refer to the Prow job failure: https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_etcd/20796/pull-etcd-verify/1979810317445632000#
|
eb48c66 to
5598b5d
Compare
|
I have rebased and fixed the broken links. |
ivanvc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @ronaldngounou. This is a great start. I left some comments. Please take a look at them.
|
Feedback is addressed |
|
/assign |
261530a to
56f9a51
Compare
|
/retest |
ivanvc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the updates, @ronaldngounou. I left some comments after the update.
- Introduction to Prow - How Prow is used for etcd testing - Navigating perfomance dashboards (Grafana) - Prow job categories - Interpreting metrics Signed-off-by: ronaldngounou <[email protected]>
56f9a51 to
e6a773b
Compare
|
Feedback is addressed @ivanvc |
Overview
This PR documents how etcd contributors can navigate performance of prow jobs.
Contributes to issue #18707