[Antithesis] Migrate from fixed paths to env-based vars #20794
Conversation
nwnt
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 19 files with indirect coverage changes @@ Coverage Diff @@
## main #20794 +/- ##
=======================================
Coverage 69.19% 69.20%
=======================================
Files 422 422
Lines 34821 34824 +3
=======================================
+ Hits 24096 24101 +5
+ Misses 9326 9323 -3
- Partials 1399 1400 +1 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| dataPaths = parseDataPaths(envDataPaths) | ||
| hosts = make([]string, 0, len(dataPaths)) | ||
| for host := range dataPaths { | ||
| hosts = append(hosts, host+":2379") |
There was a problem hiding this comment.
Thought that ETCD_ROBUSTNESS_ENDPOINTS already include port numbers.
There was a problem hiding this comment.
My bad, I didn't include this part in the code. This is now fixed.
nwnt
force-pushed
the
switch-to-paths-from-envs
branch
from
e13cfd6 to
3b9c2ee
Compare
nwnt
force-pushed
the
switch-to-paths-from-envs
branch
from
3b9c2ee to
8382b93
Compare
Signed-off-by: Nont <[email protected]>
nwnt
force-pushed
the
switch-to-paths-from-envs
branch
from
8382b93 to
04ed940
Compare
|
/retest |
| _, reportPath, dirs := common.DefaultPaths(cfg) | ||
| _, reportPath, dirs := common.GetPaths(cfg) | ||
| if *local { | ||
| _, reportPath, dirs = common.LocalPaths(cfg) |
There was a problem hiding this comment.
For the future, would also good to move LocalPaths into GetPaths
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nwnt, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
As a continuation of breaking #20736 down, I'm making the clients' data and report paths configurable from the new environment variables (DATA_PATHS and REPORT_PATH).
@serathius