Skip to content

Conversation

@jprieto-temporal
Copy link

The rangeLimit function was incorrectly setting limit=0 (fetch everything) for all sort operations, including the common case of sorting by key in ascending order. Since the backend already returns keys in lexicographically ascending order, we can preserve the limit for this case to improve performance and reduce memory usage.

This change modifies the condition to only fetch everything when:

  • Sort order is not NONE AND
  • Sort is not by key in ascending order (the default backend order) OR
  • Revision filters are applied

Fixes #20745

The rangeLimit function was incorrectly setting limit=0 (fetch everything) 
for all sort operations, including the common case of sorting by key in 
ascending order. Since the backend already returns keys in lexicographically 
ascending order, we can preserve the limit for this case to improve 
performance and reduce memory usage.

This change modifies the condition to only fetch everything when:
- Sort order is not NONE AND
- Sort is not by key in ascending order (the default backend order) OR
- Revision filters are applied

Fixes etcd-io#20745
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jprieto-temporal
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @jprieto-temporal. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Range requests with limit ignore limit when sorting by key ascending

2 participants