etcdserver: keep range request limit when sorting by key ascending #20746
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rangeLimit function was incorrectly setting limit=0 (fetch everything) for all sort operations, including the common case of sorting by key in ascending order. Since the backend already returns keys in lexicographically ascending order, we can preserve the limit for this case to improve performance and reduce memory usage.
This change modifies the condition to only fetch everything when:
Fixes #20745