Skip to content

Fix number of operations is more than the key pool size#20032

Merged
serathius merged 1 commit intoetcd-io:mainfrom
serathius:antithesis-keypool-size
May 27, 2025
Merged

Fix number of operations is more than the key pool size#20032
serathius merged 1 commit intoetcd-io:mainfrom
serathius:antithesis-keypool-size

Conversation

@serathius
Copy link
Member

@serathius serathius commented May 27, 2025

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Fixes

[        30.379] [robustness/singleton_driver_traffic] [err] panic: GetKeysForMultiTxnOps: number of operations is more than the key pool size
[        30.379] [robustness/singleton_driver_traffic] [err] goroutine 184 [running]:
[        30.379] [robustness/singleton_driver_traffic] [err] go.etcd.io/etcd/tests/v3/robustness/traffic.(*keyStore).GetKeysForMultiTxnOps(0xc000470f40, {0xc00059f488, 0x4, 0x0?})
[        30.380] [robustness/singleton_driver_traffic] [err] 	/build/tests/robustness/traffic/key_store.go:77 +0x485
[        30.381] [robustness/singleton_driver_traffic] [err] go.etcd.io/etcd/tests/v3/robustness/traffic.etcdTrafficClient.pickMultiTxnOps({{0xa, {0x1b6f760, 0x7, 0x7}, 0x1c20, 0x8001}, 0xc000470f40, 0xc000254288, 0xc0005061e0, {0x14e94d8, ...}, ...}, ...)
[        30.381] [robustness/singleton_driver_traffic] [err] 	/build/tests/robustness/traffic/etcd.go:367 +0x62a
[        30.382] [robustness/singleton_driver_traffic] [err] go.etcd.io/etcd/tests/v3/robustness/traffic.etcdTrafficClient.Request({{0xa, {0x1b6f760, 0x7, 0x7}, 0x1c20, 0x8001}, 0xc000470f40, 0xc000254288, 0xc0005061e0, {0x14e94d8, ...}, ...}, ...)
[        30.382] [robustness/singleton_driver_traffic] [err] 	/build/tests/robustness/traffic/etcd.go:272 +0x9db
[        30.383] [robustness/singleton_driver_traffic] [err] go.etcd.io/etcd/tests/v3/robustness/traffic.etcdTraffic.RunTrafficLoop({0xa, {0x1b6f760, 0x7, 0x7}, 0x1c20, 0x8001}, {0x14eccd0, 0x2b41e20}, 0xc000254288, 0xc0005061e0, ...)
[        30.383] [robustness/singleton_driver_traffic] [err] 	/build/tests/robustness/traffic/etcd.go:159 +0x316
[        30.383] [robustness/singleton_driver_traffic] [err] main.simulateTraffic.func1(0xc000254288)
[        30.383] [robustness/singleton_driver_traffic] [err] 	/build/tests/antithesis/test-template/robustness/traffic/main.go:140 +0x238
[        30.383] [robustness/singleton_driver_traffic] [err] created by main.simulateTraffic in goroutine 163
[        30.383] [robustness/singleton_driver_traffic] [err] 	/build/tests/antithesis/test-template/robustness/traffic/main.go:136 +0x38b

In Antithesis we just run 3 clients, which is lower than number of operations in the MultiOpTxn which requires 4 keys being used.
/assign @ahrtr

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius
Copy link
Member Author

/cc @joshjms

@k8s-ci-robot k8s-ci-robot requested a review from joshjms May 27, 2025 09:43
@joshjms
Copy link
Member

joshjms commented May 27, 2025

Ah, makes sense, lgtm

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joshjms, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit ae01ad8 into etcd-io:main May 27, 2025
16 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants