Skip to content

Move parseArgs into e2e framework#20016

Merged
ahrtr merged 1 commit intoetcd-io:mainfrom
ahrtr:patchargs_20250523
May 23, 2025
Merged

Move parseArgs into e2e framework#20016
ahrtr merged 1 commit intoetcd-io:mainfrom
ahrtr:patchargs_20250523

Conversation

@ahrtr
Copy link
Member

@ahrtr ahrtr commented May 23, 2025

Extracted from #20001, to make review of that PR easier.

cc @serathius

Signed-off-by: Benjamin Wang <benjamin.ahrtr@gmail.com>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.78%. Comparing base (55ee500) to head (6c807b3).
Report is 4 commits behind head on main.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20016      +/-   ##
==========================================
- Coverage   68.81%   68.78%   -0.04%     
==========================================
  Files         424      424              
  Lines       35764    35764              
==========================================
- Hits        24611    24599      -12     
- Misses       9736     9744       +8     
- Partials     1417     1421       +4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ee500...6c807b3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahrtr ahrtr merged commit 6e2be32 into etcd-io:main May 23, 2025
33 checks passed
@ahrtr ahrtr deleted the patchargs_20250523 branch May 23, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants