dependency: bump github.com/olekukonko/tablewriter from 0.0.5 to 1.0.6#20008
Conversation
* Updates changes to version 1.0.x API to build tables. * Updates the bill of materials. Dependabot pull request: etcd-io#19978 Signed-off-by: Ivan Valdes <ivan@vald.es>
ivanvc
force-pushed
the
bump-tablewriter-to-1.0.6
branch
from
7b485b3 to
4312b20
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 23 files with indirect coverage changes @@ Coverage Diff @@
## main #20008 +/- ##
==========================================
- Coverage 68.80% 68.78% -0.02%
==========================================
Files 424 424
Lines 35764 35764
==========================================
- Hits 24606 24602 -4
- Misses 9740 9744 +4
Partials 1418 1418 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
It looks good to me. By the way just fixing the link for the migration guide: https://github.com/olekukonko/tablewriter/blob/master/MIGRATION.md. The change makes a lot of sense, thanks Ivan |
Thanks. I updated the link in the description, too. |
|
@ivanvc can you provide examples of the command output after the change? thx |
The output is the same. Ideally, we should have tests for the CLI tools, but that's where we have the least coverage. Before: $ git checkout main
Switched to branch 'main'
Your branch is up to date with 'origin/main'.
$ rm -rf ./bin && make build &>/dev/null
$ ./bin/etcdutl hashkv -w table ./default.etcd/member/snap/db
+------------+---------------+------------------+
| HASH | HASH REVISION | COMPACT REVISION |
+------------+---------------+------------------+
| 1084519789 | 1 | -1 |
+------------+---------------+------------------+After: $ gh co 20008
Switched to branch 'bump-tablewriter-to-1.0.6'
Your branch is up to date with 'ivanvc/bump-tablewriter-to-1.0.6'.
Already up to date.
$ rm -rf ./bin && make build &>/dev/null
$ ./bin/etcdutl hashkv -w table ./default.etcd/member/snap/db
┌────────────┬───────────────┬──────────────────┐
│ HASH │ HASH REVISION │ COMPACT REVISION │
├────────────┼───────────────┼──────────────────┤
│ 1084519789 │ 1 │ -1 │
└────────────┴───────────────┴──────────────────┘ |
|
thx for checking it. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4 participants
Dependabot pull request: #19978
The table printers could be improved to keep them DRY (i.e., there's a lot of code repetition), and we could use
table.Bulk()to add the items in bulk rather than iterating (refer to tablewriter migration guide). However, to keep the scope of the pull request small, it could be done in a follow-up PR.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.