Antithesis: Use RecordingClient from robustness tests#19834
Antithesis: Use RecordingClient from robustness tests#19834serathius merged 1 commit intoetcd-io:mainfrom
Conversation
|
Skipping CI for Draft Pull Request. |
057ff20 to
7d19a9c
Compare
|
/ok-to-test |
|
|
||
| hosts := [][]string{{"etcd0:2379"}, {"etcd1:2379"}, {"etcd2:2379"}} | ||
| hosts := []string{"etcd0:2379", "etcd1:2379", "etcd2:2379"} | ||
| host := random.RandomChoice(hosts) |
There was a problem hiding this comment.
| host := random.RandomChoice(hosts) |
There was a problem hiding this comment.
@serathius should we remove this? We are using it in our Antithesis Assertion step.
There was a problem hiding this comment.
Or do you just want me to use host[0] for it?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 42 files with indirect coverage changes @@ Coverage Diff @@
## main #19834 +/- ##
==========================================
+ Coverage 68.54% 68.84% +0.29%
==========================================
Files 416 424 +8
Lines 35677 35862 +185
==========================================
+ Hits 24456 24690 +234
+ Misses 9786 9748 -38
+ Partials 1435 1424 -11 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Signed-off-by: Abdur Rehman <razashahid107@gmail.com>
7d19a9c to
1ba42ce
Compare
|
@abdurrehman107: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abdurrehman107, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR addresses this issue. We wish to use the
RecordingClientexisting in the robustness test client library.cc @serathius