Skip to content

Antithesis: Use RecordingClient from robustness tests#19834

Merged
serathius merged 1 commit intoetcd-io:mainfrom
abdurrehman107:abdur-rehman/antithesis-pr-5
Apr 30, 2025
Merged

Antithesis: Use RecordingClient from robustness tests#19834
serathius merged 1 commit intoetcd-io:mainfrom
abdurrehman107:abdur-rehman/antithesis-pr-5

Conversation

@abdurrehman107
Copy link
Member

This PR addresses this issue. We wish to use the RecordingClient existing in the robustness test client library.
cc @serathius

@k8s-ci-robot
Copy link

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@serathius
Copy link
Member

/ok-to-test

@serathius serathius marked this pull request as ready for review April 29, 2025 21:39

hosts := [][]string{{"etcd0:2379"}, {"etcd1:2379"}, {"etcd2:2379"}}
hosts := []string{"etcd0:2379", "etcd1:2379", "etcd2:2379"}
host := random.RandomChoice(hosts)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
host := random.RandomChoice(hosts)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@serathius should we remove this? We are using it in our Antithesis Assertion step.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or do you just want me to use host[0] for it?

@codecov
Copy link

codecov bot commented Apr 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.84%. Comparing base (1a3a5a4) to head (7d19a9c).
Report is 8 commits behind head on main.

Current head 7d19a9c differs from pull request most recent head 1ba42ce

Please upload reports for the commit 1ba42ce to get more accurate results.

Additional details and impacted files

see 42 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19834      +/-   ##
==========================================
+ Coverage   68.54%   68.84%   +0.29%     
==========================================
  Files         416      424       +8     
  Lines       35677    35862     +185     
==========================================
+ Hits        24456    24690     +234     
+ Misses       9786     9748      -38     
+ Partials     1435     1424      -11     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a3a5a4...1ba42ce. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Abdur Rehman <razashahid107@gmail.com>
@abdurrehman107 abdurrehman107 force-pushed the abdur-rehman/antithesis-pr-5 branch from 7d19a9c to 1ba42ce Compare April 29, 2025 22:28
@k8s-ci-robot
Copy link

@abdurrehman107: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-coverage-report 1ba42ce link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abdurrehman107, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 43a43f3 into etcd-io:main Apr 30, 2025
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants