Skip to content

Fix antithesis docker file removing distroless layer.#19824

Merged
serathius merged 1 commit intoetcd-io:mainfrom
serathius:antithesis-dockerfile
Apr 29, 2025
Merged

Fix antithesis docker file removing distroless layer.#19824
serathius merged 1 commit intoetcd-io:mainfrom
serathius:antithesis-dockerfile

Conversation

@serathius
Copy link
Member

As antithesis requires CGO we cannot compile binary staticly.

/cc @jmhbnz @ivanvc @nwnt

@k8s-ci-robot k8s-ci-robot requested review from ivanvc and jmhbnz April 29, 2025 10:41
@k8s-ci-robot
Copy link

@serathius: GitHub didn't allow me to request PR reviews from the following users: nwnt.

Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

As antithesis requires CGO we cannot compile binary staticly.

/cc @jmhbnz @ivanvc @nwnt

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

As antithesis requires CGO we cannot compile binary staticly.

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius serathius force-pushed the antithesis-dockerfile branch from 1ae62a1 to e80f325 Compare April 29, 2025 10:43
@serathius serathius changed the title Fix antithesis docker file removing distroless image. Fix antithesis docker file removing distroless layer. Apr 29, 2025
@serathius
Copy link
Member Author

/retest
/cc @ahrtr

@k8s-ci-robot k8s-ci-robot requested a review from ahrtr April 29, 2025 11:19
@serathius
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link

@serathius: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-coverage-report e80f325 link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@serathius
Copy link
Member Author

/cc @fuweid

@k8s-ci-robot k8s-ci-robot requested a review from fuweid April 29, 2025 14:38
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fuweid, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 021aece into etcd-io:main Apr 29, 2025
29 of 30 checks passed
@fuweid
Copy link
Member

fuweid commented Apr 29, 2025

   leak.go:119: Test appears to have leaked :
        context.(*cancelCtx).propagateCancel.func2()
        	/usr/local/go/src/context/context.go:514 +0x98
        created by context.(*cancelCtx).propagateCancel in goroutine 108555
        	/usr/local/go/src/context/context.go:513 +0x3e6
        
        go.etcd.io/etcd/client/v3.(*watchGRPCStream).serveSubstream.func1()
        	/home/prow/go/src/github.com/etcd-io/etcd/client/v3/watch.go:797 +0x93
        go.etcd.io/etcd/client/v3.(*watchGRPCStream).serveSubstream(0xc015075790, 0xc0019dcfd0, 0xc00d26e540)
        	/home/prow/go/src/github.com/etcd-io/etcd/client/v3/watch.go:822 +0x624
        created by go.etcd.io/etcd/client/v3.(*watchGRPCStream).run in goroutine 108936
        	/home/prow/go/src/github.com/etcd-io/etcd/client/v3/watch.go:563 +0xdb9
        
        sync.runtime_SemacquireWaitGroup(0x4?)
        	/usr/local/go/src/runtime/sema.go:110 +0x25
        sync.(*WaitGroup).Wait(0x7fb2d02bfb70?)
        	/usr/local/go/src/sync/waitgroup.go:118 +0x48
        go.etcd.io/etcd/client/v3.(*watchGRPCStream).run.func1()
        	/home/prow/go/src/github.com/etcd-io/etcd/client/v3/watch.go:532 +0x391
        go.etcd.io/etcd/client/v3.(*watchGRPCStream).run(0xc015075790)
        	/home/prow/go/src/github.com/etcd-io/etcd/client/v3/watch.go:680 +0x1a84
        created by go.etcd.io/etcd/client/v3.(*watcher).newWatcherGRPCStream in goroutine 108555
        	/home/prow/go/src/github.com/etcd-io/etcd/client/v3/watch.go:293 +0x316
--- FAIL: TestElectionWithAuthEnabled (16.55s)

It looks like we have flaky case but we did call Close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants