Skip to content

Simplify apply by handling membership apply through the same applyV3 stack#19813

Merged
serathius merged 1 commit intoetcd-io:mainfrom
serathius:refactor-membership-apply
Apr 29, 2025
Merged

Simplify apply by handling membership apply through the same applyV3 stack#19813
serathius merged 1 commit intoetcd-io:mainfrom
serathius:refactor-membership-apply

Conversation

@serathius
Copy link
Member

@serathius
Copy link
Member Author

/retest

@codecov
Copy link

codecov bot commented Apr 26, 2025

Codecov Report

Attention: Patch coverage is 73.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 64.75%. Comparing base (3cf32c0) to head (a3635cd).
Report is 13 commits behind head on main.

Current head a3635cd differs from pull request most recent head a286590

Please upload reports for the commit a286590 to get more accurate results.

Files with missing lines Patch % Lines
server/etcdserver/apply/uber_applier.go 68.18% 7 Missing ⚠️
server/etcdserver/apply/apply.go 80.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/apply/apply_auth.go 100.00% <100.00%> (ø)
server/etcdserver/server.go 82.79% <100.00%> (+0.45%) ⬆️
server/etcdserver/apply/apply.go 77.52% <80.00%> (-0.51%) ⬇️
server/etcdserver/apply/uber_applier.go 83.09% <68.18%> (-3.09%) ⬇️

... and 73 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19813      +/-   ##
==========================================
- Coverage   68.84%   64.75%   -4.10%     
==========================================
  Files         421      421              
  Lines       35863    35844      -19     
==========================================
- Hits        24690    23210    -1480     
- Misses       9747    11229    +1482     
+ Partials     1426     1405      -21     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 021aece...a286590. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius
Copy link
Member Author

PTAL @fuweid

@serathius
Copy link
Member Author

/retest

@serathius serathius force-pushed the refactor-membership-apply branch 3 times, most recently from 7f38b22 to 958e647 Compare April 29, 2025 15:55
…stack

Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@serathius serathius force-pushed the refactor-membership-apply branch from 958e647 to a286590 Compare April 29, 2025 15:57
@serathius
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fuweid, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link

k8s-ci-robot commented Apr 29, 2025

@serathius: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-coverage-report a286590 link true /test pull-etcd-coverage-report

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@serathius serathius merged commit 88bba4d into etcd-io:main Apr 29, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants