Skip to content

[release-3.5] emit compaction pause duration metric in every compaction batch#19771

Merged
fuweid merged 1 commit intoetcd-io:release-3.5from
k8s-infra-cherrypick-robot:cherry-pick-19762-to-release-3.5
Apr 24, 2025
Merged

[release-3.5] emit compaction pause duration metric in every compaction batch#19771
fuweid merged 1 commit intoetcd-io:release-3.5from
k8s-infra-cherrypick-robot:cherry-pick-19762-to-release-3.5

Conversation

@k8s-infra-cherrypick-robot

This is an automated cherry-pick of #19762

/assign ahrtr

Previously, the compaction pause duration metric was skipped if the number
of keys was smaller than `batchNum`, leading to gaps in monitoring data.
This change ensures the metric is emitted for every batch, regardless of
key count.

Signed-off-by: Miancheng Lin <iml@amazon.com>
@k8s-ci-robot
Copy link

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Apr 21, 2025

/ok-to-test

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fuweid fuweid merged commit 89ed73c into etcd-io:release-3.5 Apr 24, 2025
27 checks passed
@ivanvc ivanvc mentioned this pull request Jul 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants