[release-3.6] emit compaction pause duration metric in every compaction batch#19770
Conversation
Previously, the compaction pause duration metric was skipped if the number of keys was smaller than `batchNum`, leading to gaps in monitoring data. This change ensures the metric is emitted for every batch, regardless of key count. Signed-off-by: Miancheng Lin <iml@amazon.com>
|
Hi @k8s-infra-cherrypick-robot. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 19 files with indirect coverage changes @@ Coverage Diff @@
## release-3.6 #19770 +/- ##
============================================
Coverage 68.92% 68.93%
============================================
Files 420 420
Lines 35607 35608 +1
============================================
+ Hits 24543 24546 +3
- Misses 9638 9639 +1
+ Partials 1426 1423 -3 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, k8s-infra-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ahrtr, should this be highlighted in the CHANGELOG? |
Yes, I believe so, #19762 (comment) |
6 participants
This is an automated cherry-pick of #19762
/assign ahrtr