Add instruction to change golang version when building image

[joshjms]

Add clearer description to update GOLANG_VERSION when building new etcd image.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[k8s-ci-robot]

Hi @joshjms. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[joshjms]

Hi @ahrtr , I have in the documentation

2. In cluster/images/etcd/Makefile, include the new version in BUNDLED_ETCD_VERSIONS and update the LATEST_ETCD_VERSION as well (the image tag will be generated from the LATEST_ETCD_VERSION). Update GOLANG_VERSION if necessary.

I'll changed the last sentence to

Update GOLANG_VERSION according to the version used to compile that release version (can be seen in the CHANGELOG).

[ahrtr]

We need to update the go version in build/dependencies.yaml if needed, and ensure the go version matches the go version used in cluster/images/etcd/Makefile

[joshjms]

1. In build/dependencies.yaml, update the version of etcd-image and golang: etcd release version to the new version.

It appears I didn't add an example for that. I made the instruction clearer and added an example below it. PTAL!

[ahrtr]

can you please squash the commits?

[joshjms]

Ohh sorry" I forgot. Done!

[ahrtr]

LGTM

Thanks

[ahrtr]

/ok-to-test

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (d4db438) to head (08c09be).
Report is 95 commits behind head on main.

Additional details and impacted files

see 22 files with indirect coverage changes

@@           Coverage Diff           @@
##             main   #19753   +/-   ##
=======================================
  Coverage   68.79%   68.80%           
=======================================
  Files         421      421           
  Lines       35857    35858    +1     
=======================================
+ Hits        24669    24673    +4     
- Misses       9762     9764    +2     
+ Partials     1426     1421    -5     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4db438...08c09be. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[joshjms]

/test pull-etcd-markdown-lint

[jmhbnz]

LGTM - Thanks @joshjms

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, jmhbnz, joshjms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,jmhbnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment