Skip to content

grpcproxy: add support for WatchRequest_ProgressRequest#19711

Open
alexandrevilain wants to merge 1 commit intoetcd-io:mainfrom
alexandrevilain:fix/grpcproxy/support-progress-requests
Open

grpcproxy: add support for WatchRequest_ProgressRequest#19711
alexandrevilain wants to merge 1 commit intoetcd-io:mainfrom
alexandrevilain:fix/grpcproxy/support-progress-requests

Conversation

@alexandrevilain
Copy link

Fixes #19710

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alexandrevilain
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @alexandrevilain. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@alexandrevilain alexandrevilain force-pushed the fix/grpcproxy/support-progress-requests branch from cc944d6 to 4b202ef Compare April 4, 2025 13:58
@alexandrevilain alexandrevilain force-pushed the fix/grpcproxy/support-progress-requests branch from 4b202ef to 8b9dd9a Compare April 7, 2025 07:51
@k8s-ci-robot k8s-ci-robot added size/M and removed size/S labels Apr 7, 2025
@henrybear327
Copy link
Contributor

/ok-to-test

@codecov
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

❌ Patch coverage is 68.75000% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.32%. Comparing base (edfcadc) to head (4dfd84d).

Files with missing lines Patch % Lines
server/proxy/grpcproxy/watch.go 61.53% 3 Missing and 2 partials ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
server/proxy/grpcproxy/watcher.go 92.15% <100.00%> (+0.32%) ⬆️
server/proxy/grpcproxy/watch.go 90.72% <61.53%> (-7.07%) ⬇️

... and 25 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19711      +/-   ##
==========================================
+ Coverage   69.25%   69.32%   +0.06%     
==========================================
  Files         422      422              
  Lines       34819    34834      +15     
==========================================
+ Hits        24115    24148      +33     
+ Misses       9314     9299      -15     
+ Partials     1390     1387       -3     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edfcadc...4dfd84d. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@alexandrevilain
Copy link
Author

/retest

@alexandrevilain alexandrevilain force-pushed the fix/grpcproxy/support-progress-requests branch from 8b9dd9a to add9f2b Compare April 22, 2025 09:04
@alexandrevilain
Copy link
Author

/retest

@alexandrevilain alexandrevilain force-pushed the fix/grpcproxy/support-progress-requests branch from add9f2b to 3c48c1f Compare April 22, 2025 09:34
@alexandrevilain alexandrevilain force-pushed the fix/grpcproxy/support-progress-requests branch from 3c48c1f to 26c34e3 Compare April 23, 2025 09:21
@alexandrevilain alexandrevilain force-pushed the fix/grpcproxy/support-progress-requests branch from 26c34e3 to 63e4f0b Compare April 24, 2025 15:10
@alexandrevilain
Copy link
Author

Hi!
Can someone please re-review the new implementation ?
Thanks :)

@alexandrevilain
Copy link
Author

@serathius Is there something I can do to get this PR merged ?
Thanks :)

Signed-off-by: alexandre.vilain <alexandre.vilain@corp.ovh.com>
@alexandrevilain alexandrevilain force-pushed the fix/grpcproxy/support-progress-requests branch from 63e4f0b to 4dfd84d Compare October 8, 2025 11:55
@k8s-ci-robot
Copy link

k8s-ci-robot commented Oct 8, 2025

@alexandrevilain: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci-etcd-robustness-release36-amd64 63e4f0b link true /test ci-etcd-robustness-release36-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@alexandrevilain
Copy link
Author

/retest-required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Missing support for ProgressRequest in gRPC proxy

5 participants