changelog: update GO entry to reflect 1.22.12 update #19338
Conversation
|
Hi @marcelfranca. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
marcelfranca
force-pushed
the
issue/19333-changelog-1.22.12
branch
from
6b9bc4b to
1050a64
Compare
There was a problem hiding this comment.
Hi, @marcelfranca. Thanks for your pull request. Please take a look at my comment.
CHANGELOG/CHANGELOG-3.5.md
Outdated
| @@ -31,7 +31,7 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/ | |||
|
|
|||
| ### Dependencies | |||
| - Bump [golang-jwt/jwt to 4.5.1 to address GO-2024-3250](https://github.com/etcd-io/etcd/pull/18899). | |||
| - Compile binaries using [go 1.22.11](https://github.com/etcd-io/etcd/pull/19211). | |||
There was a problem hiding this comment.
Please add a new entry in v3.5.19, as v3.5.18 is already released.
|
Thanks, @marcelfranca. Now, could you please squash your commits? Thanks again :) /ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 26 files with indirect coverage changes @@ Coverage Diff @@
## main #19338 +/- ##
==========================================
- Coverage 68.84% 68.83% -0.01%
==========================================
Files 420 420
Lines 35716 35716
==========================================
- Hits 24587 24585 -2
- Misses 9695 9706 +11
+ Partials 1434 1425 -9 Continue to review full report in Codecov by Sentry.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, marcelfranca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Marcel Franca <[email protected]>
marcelfranca
force-pushed
the
issue/19333-changelog-1.22.12
branch
from
4ae8012 to
14b90f7
Compare
|
/retest |
Update 3.4.36 and 3.5.18 to reflect the go 1.22.12 Update
Subtask of #19333