Add tests for NewConfig matching AddFlags defaults #19247
Conversation
Signed-off-by: Marek Siarkowicz <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 23 files with indirect coverage changes @@ Coverage Diff @@
## main #19247 +/- ##
==========================================
+ Coverage 68.77% 68.78% +0.01%
==========================================
Files 420 420
Lines 35649 35649
==========================================
+ Hits 24518 24522 +4
+ Misses 9705 9702 -3
+ Partials 1426 1425 -1 Continue to review full report in Codecov by Sentry.
|
|
/retest |
| // TODO: Remove the following assigments when both match. | ||
| newConfig.SelfSignedCertValidity = 1 | ||
| newConfig.TlsMinVersion = string(tlsutil.TLSVersion12) | ||
| newConfig.DiscoveryCfg.Secure.InsecureTransport = true | ||
| newConfig.AutoCompactionRetention = "0" | ||
| newConfig.ExperimentalDistributedTracingAddress = "localhost:4317" | ||
| newConfig.ExperimentalDistributedTracingServiceName = "etcd" | ||
| newConfig.LogFormat = "json" | ||
| newConfig.ExperimentalTxnModeWriteWithSharedBuffer = true | ||
| // TODO: Reduce number of unexported fields set in config | ||
| if diff := cmp.Diff(newConfig, cfg, cmpopts.IgnoreUnexported(transport.TLSInfo{}, Config{}), cmp.Comparer(func(a, b featuregate.FeatureGate) bool { |
There was a problem hiding this comment.
Are you going to resolve the TODO in this PR or in a followup PR?
Also I am a little confused why cfg and newConfg match even after you change some fields' value for newConfig? Why we do not see workflow failure? Did I miss anything?
There was a problem hiding this comment.
Yes, this PR shows the differences between the defaults and AddFlags, I plan to fix it in next PR.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @ahrtr @fuweid @AwesomePatrol @siyuanfoundation