Correct compaction period comments #19192
Conversation
|
Hi @wodeyoulai. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Related to #19017 |
|
Please signoff the commit, |
Thanks! I'll make the adjustments later. |
@ahrtr cc |
|
/ok-to-test |
|
Please squash the commits |
wodeyoulai
force-pushed
the
main
branch
3 times, most recently
from
443df64 to
af9b2ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
... and 22 files with indirect coverage changes @@ Coverage Diff @@
## main #19192 +/- ##
==========================================
- Coverage 68.80% 68.78% -0.02%
==========================================
Files 420 420
Lines 35650 35650
==========================================
- Hits 24529 24522 -7
- Misses 9694 9706 +12
+ Partials 1427 1422 -5 Continue to review full report in Codecov by Sentry.
|
|
We fixed some test issues, please rebase this PR, thx |
Update compaction period logic in periodic compactor to consistently use 24-hour intervals instead of 1-hour. This fixes incorrect time calculations where: - Compaction period now correctly uses 24-hour instead of 1-hour - Revision recording interval updated to 144-minute (1/10 of 24-hour) instead of 6-minute - Retry interval on compaction failure adjusted to 144-minute to match the new period This ensures consistent time-based compaction behavior for 24-hour windows as originally intended. Fixes #[issue-19017] Signed-off-by: wodeyoulai <[email protected]>
Finished |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, wodeyoulai The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
As a new contributor getting familiar with the codebase for the first time, I noticed some inconsistencies in the comments describing the compaction period timing.