-
Notifications
You must be signed in to change notification settings - Fork 9.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
etcdserver: add auto compaction interval option #18472
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jrcichra The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @jrcichra. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
My implementation here tries to support both |
/ok-to-test |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files
... and 15 files with indirect coverage changes @@ Coverage Diff @@
## main #18472 +/- ##
==========================================
+ Coverage 68.75% 68.84% +0.09%
==========================================
Files 420 420
Lines 35522 35537 +15
==========================================
+ Hits 24423 24467 +44
+ Misses 9677 9641 -36
- Partials 1422 1429 +7 Continue to review full report in Codecov by Sentry.
|
9437d43
to
5167a62
Compare
/retest |
5167a62
to
3a824ea
Compare
I'm passing all the tests now. @jmhbnz how should I proceed? I see there's a codecov report but there's a large section of code I didn't touch regarding failed auto compaction. |
/assign |
@moficodes Thanks for assigning! Let me know of any changes I should make. |
With enough key revisions per second, the constant 5 minute interval on revision compaction isn't fast enough to keep up with growth. Make the interval configurable, which will override the default behavior. Also pass the configuration through to periodic compaction for finer control of when compaction happens based on time. Fixes: etcd-io#18471 Signed-off-by: Justin Cichra <[email protected]>
3a824ea
to
98f118a
Compare
Rebase is complete 🎉 |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
With enough key revisions per second, the constant 5 minute interval on revision compaction isn't fast enough to keep up with growth. Make the interval configurable, which will override the default behavior.
Also pass the configuration through to periodic compaction for finer control of when compaction happens based on time.
Fixes:
#18471