Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github workflow: update golangci-lint to 1.55.2 #16903

Merged
merged 2 commits into from
Nov 10, 2023
Merged

Conversation

moficodes
Copy link
Member

fixes: #16897
update golangci-lint version to the latest to keep the codebase linting up to date

fixes: etcd-io#16897
update golangci-lint version to the latest to keep the codebase linting up to date

Signed-off-by: Mofi Rahman <[email protected]>
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green - Thanks @moficodes

@ahrtr ahrtr merged commit c0bb57a into etcd-io:main Nov 10, 2023
@ahrtr
Copy link
Member

ahrtr commented Nov 10, 2023

Oops, I just saw that there are two commits. Please rebase the PR instead of merging main to dev branch next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

remove unnecessary else block on test
3 participants