Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] Automated cherry-pick of #14860: Trigger release in current branch for github workflow case #15443

Conversation

ArkaSaha30
Copy link
Contributor

This PR is an automated cherry-pick of #14860 : Trigger release in current branch for github workflow case.

Conversation ref: #15424 (comment)

Signed-off-by: ArkaSaha30 [email protected]

@ArkaSaha30
Copy link
Contributor Author

/assign @ahrtr

@ahrtr
Copy link
Member

ahrtr commented Mar 10, 2023

release-3.5 & 3.4 are different from the main branch, I don't think automated cherry-pick can work. Please verify the release script & command locally firstly.

@ahrtr ahrtr changed the title Automated cherry-pick of #14860: Trigger release in current branch for github workflow case [3.5] Automated cherry-pick of #14860: Trigger release in current branch for github workflow case Mar 10, 2023
@ArkaSaha30 ArkaSaha30 force-pushed the automated-cherry-pick-of-#14860-upstream-release-3.5 branch 3 times, most recently from 2cb07b9 to 3120e70 Compare March 10, 2023 07:54
…anch for github workflow case

Signed-off-by: ArkaSaha30 <[email protected]>
@ArkaSaha30 ArkaSaha30 force-pushed the automated-cherry-pick-of-#14860-upstream-release-3.5 branch from 3120e70 to 44d78bf Compare March 30, 2023 11:09
@ArkaSaha30
Copy link
Contributor Author

Hi @ahrtr, can you please take a look at this PR if it is good to merge?

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you @ArkaSaha30 and sorry for the late response.

cc @ptabor @serathius

@ArkaSaha30
Copy link
Contributor Author

Can I go ahead with backporting #14860 to release-3.4?

@ahrtr
Copy link
Member

ahrtr commented Mar 30, 2023

Can I go ahead with backporting #14860 to release-3.4?

Please hold on until this PR gets merged, thx

@ahrtr ahrtr mentioned this pull request Mar 30, 2023
@serathius serathius merged commit 8b4549d into etcd-io:release-3.5 Mar 30, 2023
@ahrtr
Copy link
Member

ahrtr commented Mar 30, 2023

Can I go ahead with backporting #14860 to release-3.4?

Please go ahead to backport this PR to release-3.4, thx @ArkaSaha30

tjungblu pushed a commit to tjungblu/etcd that referenced this pull request Jul 26, 2023
…k-of-#14860-upstream-release-3.5

[3.5] Automated cherry-pick of etcd-io#14860: Trigger release in current branch for github workflow case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants